Review main Merged

76330[TASK] Replace prophecy in EXT:form PropertyMappingConfigurationTest

Torben Hansen CR +2 V +2 Easy +14 −25 updated 10/29/22, 12:59

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 10/29/22, 12:35

  2. Nikita Hovratov commented on patch set 1 10/29/22, 12:36

    PropertyMappingConfigurationTest.php:36

    If you are on it, let's also remove these useless doc comments.
  3. Torben Hansen uploaded patch set 2 10/29/22, 12:37

  4. Torben Hansen commented on patch set 1 10/29/22, 12:38

    PropertyMappingConfigurationTest.php:36 Reply

    Done
  5. core-ci voted on patch set 1 V +1 10/29/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32894

  6. Oliver Klee voted on patch set 2 CR +1 10/29/22, 12:44

  7. core-ci voted on patch set 2 V +1 10/29/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32895

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 10/29/22, 12:51

  9. Oliver Klee voted on patch set 2 V +1 10/29/22, 12:57

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 10/29/22, 12:59

  11. Stefan Bürk merged patch set 3 10/29/22, 12:59