Review main Merged

7634[TASK] Rebuild t3lib/core_autoload.php

Oliver Hader CR +2 V +2 Hard +154 −137 updated 06/03/13, 20:49

Commit message

The autoload registry for Core classes is rebuilt and sorted
by using the class names.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Files 1

Review log 14

  1. Markus Klein commented on patch set 1 01/13/12, 00:48

    (1 inline comment)
    Releases line missing? (or left out by intention?)
  2. Tolleiv Nietsch commented on patch set 2 V 0 01/13/12, 00:48

    by team member; Looks good to me, approved
  3. Markus Klein uploaded patch set 2 01/13/12, 00:48

  4. Oliver Klee commented on patch set 2 01/13/12, 00:48

    Looks good to me, but someone else must approve
  5. Oliver Klee commented on patch set 2 01/13/12, 00:48

    This is the same as https://review.typo3.org/#change,7701 , I think.
  6. Philipp Gampe commented on patch set 1 01/13/12, 00:48

    No score; No score You should create an issue for this. That way other issue can be related to this one (for example #32744). tip for other reviewers: ignore moved lines https://gist.github.com/1202342 usage: git diff -w HEAD^ | ignore_moves.py |sort -f -k 2
  7. Philipp Gampe commented on patch set 1 01/13/12, 00:48

    Verified; Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 1 01/13/12, 00:48

    Verified; Looks good to me, but someone else must approve Fixes missing classes. Tested with #32744.
  9. Philipp Gampe commented on patch set 2 01/13/12, 00:48

    Verified; Looks good to me, but someone else must approve Reapply vote ... no changes in patch.
  10. Mr. Jenkins commented on patch set 1 01/13/12, 00:48

  11. Mr. Jenkins commented on patch set 2 01/13/12, 00:48

  12. Wouter Wolters commented on patch set 1 01/13/12, 00:48

    Looks good to me, but someone else must approve
  13. Wouter Wolters commented on patch set 2 01/13/12, 00:48

    Looks good to me, but someone else must approve
  14. Tolleiv Nietsch merged patch set 2 01/13/12, 00:48