Review 11.5 Merged

76349[BUGFIX] Properly encode error messages in FileController

Oliver Hader CR +2 V +2 Easy +1 −0 updated 11/02/22, 08:21

Commit message

Invalid file names containing special characters like `<` or `>`
are not correctly represented as text node. Error messages wrapped
in an XML node need to be properly encoded.

This was originally reported as a vulnerability, after analyzing the
scenario, the TYPO3 Security Team came to the conclusion to handle it
in public. It cannot be exploited directly without knowing the backend
form protection token of a particular user session.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oliver Hader uploaded patch set 1 10/31/22, 15:00

  2. core-ci voted on patch set 1 V +1 10/31/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32940

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/31/22, 16:58

  4. Oliver Klee voted on patch set 1 CR +1 10/31/22, 17:21

  5. Stefan Bürk voted on patch set 1 CR +1 11/01/22, 22:00

  6. Stefan Bürk voted on patch set 1 V +1 11/01/22, 22:07

  7. Oliver Hader voted on patch set 1 V +2 CR +2 11/02/22, 08:21

  8. Oliver Hader merged patch set 2 11/02/22, 08:21