Review main Merged

76351[BUGFIX] Check if variable exists before passing it to json_decode

Albrecht Köhnlein CR +2 V +2 Easy +1 −1 updated 10/31/22, 15:42

Commit message

Avoid passing a null parameter to json_decode() which would cause
a PHP deprecation

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Albrecht Köhnlein uploaded patch set 1 10/31/22, 15:30

  2. core-ci voted on patch set 1 V +1 10/31/22, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32943

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/31/22, 15:38

  4. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/31/22, 15:40

  5. Nikita Hovratov merged patch set 2 10/31/22, 15:42