Review main Merged

76355[BUGFIX] Resolve modified slugs in versioned pages of preview

Benni Mack CR +2 V +2 Normal +132 −23 updated 11/03/22, 16:40

Commit message

This change now also fetches versioned records when
previewing a workspace, allowing to also query the
versioned records if their slug has been changed.

This extends WorkspaceRestriction to have a similar
behaviour as previously known from PageRepository (pre v8 times),
to fetch versioned records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1318

  1. Benni Mack uploaded patch set 1 10/31/22, 16:57

  2. core-ci voted on patch set 1 V +1 10/31/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32948

  3. Oliver Hader commented on patch set 1 11/02/22, 12:39

    Last but not least I'm wondering why none of the test cases failed...

    PageSlugCandidateProvider.php:228

    This most probably contains duplicates - the live version and a potential draft version are selected the same time...

    PageSlugCandidateProvider.php:238

    I'm wondering why it does not work with the restriction..
  4. Benni Mack uploaded patch set 2 11/03/22, 11:58

  5. Benni Mack commented on patch set 2 11/03/22, 11:59

    PageSlugCandidateProvider.php:228 Reply

    yes. that's why we sort properly and catch the used IDs below

    PageSlugCandidateProvider.php:238 Reply

    the restriction does not contain modified records (only new + moved), as usually this is done via overlays.
  6. Benni Mack commented on patch set 2 11/03/22, 11:59

    Reply

    we did not have tests for this yet!
  7. core-ci voted on patch set 2 V +1 11/03/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33038

  8. Benni Mack uploaded patch set 3 11/03/22, 12:12

  9. core-ci voted on patch set 3 V +1 11/03/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33039

  10. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/03/22, 12:44

  11. Benni Mack uploaded patch set 4 11/03/22, 13:11

  12. Benni Mack uploaded patch set 5 11/03/22, 13:12

  13. core-ci voted on patch set 5 V +1 11/03/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33046

  14. core-ci voted on patch set 4 V +1 11/03/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33045

  15. Nikita Hovratov voted on patch set 5 V +1 CR +1 11/03/22, 15:15

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 11/03/22, 16:39

  17. Benni Mack voted on patch set 5 V +2 CR +2 11/03/22, 16:40

  18. Benni Mack merged patch set 6 11/03/22, 16:40