76355[BUGFIX] Resolve modified slugs in versioned pages of preview
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php+35 −19
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php4+6 −4
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/WorkspaceRestrictionTest.php+25 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+66 −0
Review log 1318
-
Benni Mack uploaded patch set 1 10/31/22, 16:57
-
core-ci voted on patch set 1 V +1 10/31/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32948
-
Oliver Hader commented on patch set 1 11/02/22, 12:39
Last but not least I'm wondering why none of the test cases failed...PageSlugCandidateProvider.php:228This most probably contains duplicates - the live version and a potential draft version are selected the same time...PageSlugCandidateProvider.php:238I'm wondering why it does not work with the restriction.. -
Benni Mack uploaded patch set 2 11/03/22, 11:58
-
Benni Mack commented on patch set 2 11/03/22, 11:59
PageSlugCandidateProvider.php:228Replyyes. that's why we sort properly and catch the used IDs belowPageSlugCandidateProvider.php:238Replythe restriction does not contain modified records (only new + moved), as usually this is done via overlays. -
Benni Mack commented on patch set 2 11/03/22, 11:59
Reply
we did not have tests for this yet! -
core-ci voted on patch set 2 V +1 11/03/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33038
-
Benni Mack uploaded patch set 3 11/03/22, 12:12
-
core-ci voted on patch set 3 V +1 11/03/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33039
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 11/03/22, 12:44
-
Benni Mack uploaded patch set 4 11/03/22, 13:11
-
Benni Mack uploaded patch set 5 11/03/22, 13:12
-
core-ci voted on patch set 5 V +1 11/03/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33046
-
core-ci voted on patch set 4 V +1 11/03/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33045
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 11/03/22, 15:15
-
Christian Kuhn voted on patch set 5 V +1 CR +1 11/03/22, 16:39
-
Benni Mack voted on patch set 5 V +2 CR +2 11/03/22, 16:40
-
Benni Mack merged patch set 6 11/03/22, 16:40