Review 11.5 Abandoned Breaking

76357[!!!][FEATURE] Introduce CSRF-like request-token handling

Oliver Hader CR 0 V 0 Expert +1905 −4 updated 03/13/23, 22:40

Commit message

A CSRF-like request-token handling has been introduced, to
mitigate potential cross-site requests on actions with side-effects.
This approach does not require an existing server-side user session,
but uses a nonce (number used once) as a "pre-session". The main scope
is to ensure a user actually has visited a page, before submitting
data to the web server.

Introduces package https://packagist.org/packages/firebase/php-jwt
> composer req firebase/php-jwt:^6.3.1

Existing TYPO3 installations can enable this behavior with corresponding
feature flag `security.useLoginRequestToken`. New installations are opted
in automatically to this feature.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 33

Show 13 more files

Review log 913

  1. Oliver Hader uploaded patch set 1 10/31/22, 21:50

  2. Oliver Hader uploaded patch set 2 10/31/22, 21:55

  3. core-ci voted on patch set 1 V -1 10/31/22, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32950

  4. core-ci voted on patch set 2 V +1 10/31/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32951

  5. Stefan Bürk commented on patch set 2 11/01/22, 22:00

    composer.json:57

    Can we use ^6.3.1 directly here (containing the PHP8.2 variable interpolation fix) ? (Should be raised in main also)
  6. Oliver Hader commented on patch set 2 11/02/22, 09:12

    composer.json:57 Reply

    I used `^6.0` since there might be installations using this package already. However fine for me to use 6.3.1 of course.
  7. Oliver Hader uploaded patch set 3 11/02/22, 09:46

  8. Oliver Hader commented on patch set 3 11/02/22, 09:50

    composer.json:57 Reply

    Adjust in this change-set, raised version in `main`, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/76378
  9. core-ci voted on patch set 3 V +1 11/02/22, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32977

  10. Stefan Bürk uploaded patch set 4 V +1 11/23/22, 00:03

  11. core-ci voted on patch set 4 V +1 11/23/22, 00:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34090

  12. Stefan Bürk voted on patch set 4 CR +1 11/23/22, 00:52

  13. Benni Mack abandoned the change 03/13/23, 22:40

    not going to happen to v11