76357[!!!][FEATURE] Introduce CSRF-like request-token handling
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 33
- typo3/sysext/backend/Classes/Controller/LoginController.php+10 −0
- typo3/sysext/backend/Configuration/RequestMiddlewares.php+9 −0
- typo3/sysext/backend/Resources/Private/Layouts/Login.html+1 −0
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+23 −0
- typo3/sysext/core/Classes/Context/SecurityAspect.phpnew+120 −0
- typo3/sysext/core/Classes/Middleware/RequestTokenMiddleware.phpnew+170 −0
- typo3/sysext/core/Classes/Security/JwtTrait.phpnew+87 −0
- typo3/sysext/core/Classes/Security/Nonce.phpnew+107 −0
- typo3/sysext/core/Classes/Security/NonceException.phpnew+27 −0
- typo3/sysext/core/Classes/Security/NoncePool.phpnew+169 −0
- typo3/sysext/core/Classes/Security/RequestToken.phpnew+139 −0
- typo3/sysext/core/Classes/Security/RequestTokenException.phpnew+27 −0
- typo3/sysext/core/Classes/Security/SecretIdentifier.phpnew+75 −0
- typo3/sysext/core/Classes/Security/SigningProviderInterface.phpnew+41 −0
- typo3/sysext/core/Classes/Security/SigningSecretInterface.phpnew+36 −0
- typo3/sysext/core/Classes/Security/SigningSecretResolver.phpnew+73 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/FactoryConfiguration.php+1 −0
- typo3/sysext/core/Documentation/Changelog/11.5.x/Feature-97305-IntroduceCSRF-likeRequest-tokenHandling.rstnew+155 −0
Show 13 more files
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-97305-IntroduceCSRF-likeLoginToken.rstnew+76 −0
- typo3/sysext/core/Tests/Unit/Context/SecurityAspectTest.phpnew+60 −0
- typo3/sysext/core/Tests/Unit/Security/NoncePoolTest.phpnew+135 −0
- typo3/sysext/core/Tests/Unit/Security/NonceTest.phpnew+89 −0
- typo3/sysext/core/Tests/Unit/Security/RequestTokenTest.phpnew+131 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/felogin/Classes/Controller/LoginController.php+2 −0
- typo3/sysext/felogin/Resources/Private/Templates/Login/Login.html+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+51 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+10 −0
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+10 −1
- composer.json3+1 −0
- composer.lock+63 −1
Review log 913
-
Oliver Hader uploaded patch set 1 10/31/22, 21:50
-
Oliver Hader uploaded patch set 2 10/31/22, 21:55
-
core-ci voted on patch set 1 V -1 10/31/22, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32950
-
core-ci voted on patch set 2 V +1 10/31/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32951
-
Stefan Bürk commented on patch set 2 11/01/22, 22:00
-
Oliver Hader commented on patch set 2 11/02/22, 09:12
composer.json:57ReplyI used `^6.0` since there might be installations using this package already. However fine for me to use 6.3.1 of course. -
Oliver Hader uploaded patch set 3 11/02/22, 09:46
-
Oliver Hader commented on patch set 3 11/02/22, 09:50
composer.json:57ReplyAdjust in this change-set, raised version in `main`, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/76378 -
core-ci voted on patch set 3 V +1 11/02/22, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32977
-
Stefan Bürk uploaded patch set 4
V +111/23/22, 00:03 -
core-ci voted on patch set 4 V +1 11/23/22, 00:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34090
-
Stefan Bürk voted on patch set 4 CR +1 11/23/22, 00:52
-
Benni Mack abandoned the change 03/13/23, 22:40
not going to happen to v11
composer.json:57