Review main Merged

76382[TASK] Simplify FE functional test related TypoScriptInstruction

Christian Kuhn CR +2 V +2 Easy +15 −19 updated 11/02/22, 15:41

Commit message

Raised testing-framework allows avoiding usage of the
deprecated TemplateService::class identifier when adding FE
functional test related sub requests with special TypoScript.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 611

  1. Christian Kuhn uploaded patch set 1 11/02/22, 14:09

  2. core-ci voted on patch set 1 V -1 11/02/22, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32984

  3. Christian Kuhn uploaded patch set 2 11/02/22, 14:27

  4. core-ci voted on patch set 2 V +1 11/02/22, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32985

  5. Christian Kuhn uploaded patch set 3 11/02/22, 14:49

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 11/02/22, 15:03

  7. core-ci voted on patch set 3 V +1 11/02/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32988

  8. core-ci voted on patch set 3 V -1 11/02/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32991

  9. core-ci voted on patch set 3 V +1 11/02/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32991

  10. Nikita Hovratov voted on patch set 3 V +2 CR +2 11/02/22, 15:41

  11. Nikita Hovratov merged patch set 4 11/02/22, 15:41