Review main Merged

76384[TASK] Drop ineffective TMENU caches

Loek Hilgersom CR +2 V +2 Easy +6 −33 updated 11/04/22, 13:23

Commit message

The "hash" cache for (TMENU) menu generation is
very ineffective: The cache identifier hash contains
the page rootline, so it is single page specific.

This leads to quite some pollution of the "hash"
cache, often many more entries than page cache
entries, without high re-use / cache-hit rate.

Looking closer at this, we found the menu
generation cache to be so ineffective that it's
better to not cache at all. We first thought a
runtime cache would be a good solution but even
that one is not helpful and there are further
runtime caches on lower levels already, for
instance to resolve shortcut pages.

The patch removes this cache layer, leading to
a drastically smaller "hash" cache.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1