Review main Merged

76391[TASK] Use ResourceMutex in TSFE for locking

Christian Kuhn CR +2 V +2 Normal +28 −99 updated 11/03/22, 12:05

Commit message

Class ResourceMutex is codewise identical to
acquireLock() in TypoScriptFrontendController.
Use it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1519

  1. Christian Kuhn uploaded patch set 1 11/02/22, 17:45

  2. Christian Kuhn commented on patch set 1 CR -1 11/02/22, 17:55

    looks as if this needs some fine-tuning ^^
  3. core-ci voted on patch set 1 V -1 11/02/22, 17:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33001

  4. Christian Kuhn uploaded patch set 2 11/03/22, 08:58

  5. core-ci voted on patch set 2 V +1 11/03/22, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33024

  6. Stefan Bürk commented on patch set 2 11/03/22, 09:46

    LockFactory.php:24

    Can we declare this class / file now strict ? Or speaks something against it ?
  7. Christian Kuhn uploaded patch set 3 11/03/22, 09:49

  8. Christian Kuhn commented on patch set 2 11/03/22, 09:49

    LockFactory.php:24 Reply

    yeah. i guess we can.
  9. core-ci voted on patch set 3 V +1 11/03/22, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33030

  10. Stefan Bürk voted on patch set 3 CR +1 11/03/22, 09:57

  11. Stefan Bürk voted on patch set 3 V +1 11/03/22, 10:10

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 11/03/22, 11:10

  13. Andreas Kienast uploaded patch set 4 11/03/22, 11:18

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 11/03/22, 11:19

  15. core-ci voted on patch set 4 V +1 11/03/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33036

  16. Benni Mack voted on patch set 4 V +1 CR +1 11/03/22, 11:27

  17. Stefan Bürk voted on patch set 4 V +1 CR +1 11/03/22, 11:51

  18. Christian Kuhn voted on patch set 4 V +2 CR +2 11/03/22, 12:05

  19. Christian Kuhn merged patch set 5 11/03/22, 12:05