76402[TASK] Do not ask for confirmation before creating bookmarks
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Lina Wolf +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/toolbar/shortcut-menu.ts+39 −36
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+5 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemItem.html+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/shortcut-menu.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.php+12 −6
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −3
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+2 −21
Review log 810
-
Andreas Kienast uploaded patch set 1 11/03/22, 13:29
-
core-ci voted on patch set 1 V -1 11/03/22, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33049
-
Andreas Kienast uploaded patch set 2 11/03/22, 14:09
-
core-ci voted on patch set 2 V +1 11/03/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33051
-
Christian Kuhn commented on patch set 2 11/03/22, 16:48
nitpick: when adding a bookmark, the status of the 'share' button changes to 'already bookmarked' when removing the bookmark, it does not change-back to 'create bookmark' again. -
Andreas Kienast commented on patch set 2 11/03/22, 16:52
Reply
That's already broken before this patch. I'd rather not fix this issue with this patch, but think about a possible bugfix that may get backported to v11. -
Anja Leichsenring voted on patch set 2 V +1 CR +1 11/03/22, 18:19
-
Lina Wolf commented on patch set 2 V +1 CR +1 11/03/22, 18:24
Code looks good to me and it works -
Stefan Bürk voted on patch set 2 V +2 CR +2 11/03/22, 18:34
-
Stefan Bürk merged patch set 3 11/03/22, 18:34