Review main Merged

76402[TASK] Do not ask for confirmation before creating bookmarks

Andreas Kienast CR +2 V +2 Normal +68 −70 updated 11/03/22, 18:34

Commit message

When a backend user wants to create a bookmark, the confirmation modal
that was previously in place doesn't pop up anymore as this is no
dangerous action.

Additionally, the responses of the controller are sent as a JSON string
and proper status codes.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Andreas Kienast uploaded patch set 1 11/03/22, 13:29

  2. core-ci voted on patch set 1 V -1 11/03/22, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33049

  3. Andreas Kienast uploaded patch set 2 11/03/22, 14:09

  4. core-ci voted on patch set 2 V +1 11/03/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33051

  5. Christian Kuhn commented on patch set 2 11/03/22, 16:48

    nitpick: when adding a bookmark, the status of the 'share' button changes to 'already bookmarked' when removing the bookmark, it does not change-back to 'create bookmark' again.
  6. Andreas Kienast commented on patch set 2 11/03/22, 16:52

    Reply

    That's already broken before this patch. I'd rather not fix this issue with this patch, but think about a possible bugfix that may get backported to v11.
  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/03/22, 18:19

  8. Lina Wolf commented on patch set 2 V +1 CR +1 11/03/22, 18:24

    Code looks good to me and it works
  9. Stefan Bürk voted on patch set 2 V +2 CR +2 11/03/22, 18:34

  10. Stefan Bürk merged patch set 3 11/03/22, 18:34