Review main Abandoned

76406[BUGFIX] Do not switch to page module when switching workspaces

Benni Mack CR 0 V 0 Normal +82 −50 updated 03/21/25, 21:10

Commit message

This change removes a manual hack to try to jump to a proper module,
which has a lot of side-effects, and is not useful nowadays, as the
prefix "web_" is not suited for modules anymore, as modules can now
have any kind of name.

After switching a workspace, it is determined whether the current
active module is suitable for the current workspace, which requires two
drive-by fixes:

1. refresh the module state after reloading the module by moving the
   huge JSON string out of the scaffold into the reloadable section and
   providing an internal helper method to flush the runtime cache of
   said state
2. default the workspace accessibility to an empty string in the module
   registration and fall back to the parent module configuration, if
   necessary

If a module is not suitable for entry after switching a workspace (e.g.
the "Recycler" backend module), the first available backend module is
accessed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 13

Review log 1116

  1. Benni Mack uploaded patch set 1 11/03/22, 17:05

  2. core-ci voted on patch set 1 V +1 11/03/22, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33062

  3. Christian Kuhn commented on patch set 1 V -1 11/03/22, 17:21

    this now leads to the situation that when switching live->ws and being in the sites module, the sites module is still rendered in workspaces, even though 'sites' does not exist in workspaces.
  4. Andreas Kienast uploaded patch set 2 11/04/22, 10:35

  5. core-ci voted on patch set 2 V -1 11/04/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33100

  6. Andreas Kienast uploaded patch set 3 11/04/22, 11:05

  7. core-ci voted on patch set 3 V +1 11/04/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33101

  8. Oli Bartsch uploaded patch set 4 V +1 02/17/23, 09:08

  9. core-ci voted on patch set 4 V -1 02/17/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37826

  10. Oli Bartsch uploaded patch set 5 V -1 02/17/23, 11:40

  11. core-ci voted on patch set 5 V +1 02/17/23, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37829

  12. Oli Bartsch voted on patch set 5 V +1 CR +1 02/17/23, 11:54

  13. Guido Schmechel commented on patch set 5 02/20/23, 13:59

    Basically the module change works, therefore +1 ;-) However, I have noticed the following: - Live Workspace - Click on Recycler - Switch to Edit Mode (via Toolbar) - Dashboard is selected for me (as described) - Switch to Live Mode (via Toolbar) - I am still in Dashboard (as described) - I click on Recycler => The PageTree is not visible. Only with Reload on the 3 points is it there again. (Browser Chrome / OS Windows) I am not sure now if this is caused by this patch. If known, I'm happy to give +1 because the module change worked as described.
  14. Benni Mack updated the commit message in patch set 6 CR +1 V +1 05/03/23, 09:54

  15. Benni Mack updated the commit message in patch set 7 10/18/24, 14:07

  16. Benni Mack abandoned the change 03/21/25, 21:10

    won't do it like this