76406[BUGFIX] Do not switch to page module when switching workspaces
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 13
- Build/Sources/TypeScript/backend/module-menu.ts+4 −3
- Build/Sources/TypeScript/backend/module.ts+36 −4
- Build/Sources/TypeScript/workspaces/toolbar/workspaces-menu.ts+27 −18
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −1
- typo3/sysext/backend/Classes/Module/BaseModule.php+1 −1
- typo3/sysext/backend/Classes/Module/ModuleProvider.php+2 −1
- typo3/sysext/backend/Resources/Private/Partials/Backend/ModuleMenu.html+1 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Backend/ModuleMenu.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module.js+1 −1
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+1 −16
- typo3/sysext/workspaces/Resources/Public/JavaScript/toolbar/workspaces-menu.js+1 −1
Review log 1116
-
Benni Mack uploaded patch set 1 11/03/22, 17:05
-
core-ci voted on patch set 1 V +1 11/03/22, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33062
-
Christian Kuhn commented on patch set 1 V -1 11/03/22, 17:21
this now leads to the situation that when switching live->ws and being in the sites module, the sites module is still rendered in workspaces, even though 'sites' does not exist in workspaces. -
Andreas Kienast uploaded patch set 2 11/04/22, 10:35
-
core-ci voted on patch set 2 V -1 11/04/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33100
-
Andreas Kienast uploaded patch set 3 11/04/22, 11:05
-
core-ci voted on patch set 3 V +1 11/04/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33101
-
Oli Bartsch uploaded patch set 4
V +102/17/23, 09:08 -
core-ci voted on patch set 4 V -1 02/17/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37826
-
Oli Bartsch uploaded patch set 5
V -102/17/23, 11:40 -
core-ci voted on patch set 5 V +1 02/17/23, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37829
-
Oli Bartsch voted on patch set 5 V +1 CR +1 02/17/23, 11:54
-
Guido Schmechel commented on patch set 5 02/20/23, 13:59
Basically the module change works, therefore +1 ;-) However, I have noticed the following: - Live Workspace - Click on Recycler - Switch to Edit Mode (via Toolbar) - Dashboard is selected for me (as described) - Switch to Live Mode (via Toolbar) - I am still in Dashboard (as described) - I click on Recycler => The PageTree is not visible. Only with Reload on the 3 points is it there again. (Browser Chrome / OS Windows) I am not sure now if this is caused by this patch. If known, I'm happy to give +1 because the module change worked as described. -
Benni Mack updated the commit message in patch set 6
CR +1V +105/03/23, 09:54 -
Benni Mack updated the commit message in patch set 7 10/18/24, 14:07
-
Benni Mack abandoned the change 03/21/25, 21:10
won't do it like this