Review 11.5 Merged

76414[TASK] Disable xdebug for phpstan command execution

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 11/04/22, 10:44

Commit message

PHPStan recently added a xdebug check The TYPO3 core
php testing images has xdebug installed and enabled
in cli mode, which now let PHPStan display a speaking
notice about this circumstance.

This change simply disable xdebug for phpstan calls
in runTests.sh, thus avoiding this notice. xdebug is
not needed to be enabled for PHPStan executions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 11/04/22, 10:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/04/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33099

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 11/04/22, 10:44

  4. Stefan Bürk merged patch set 2 11/04/22, 10:44