Review main Abandoned

7643[FEATURE] enable host names in settings like devIPmask This is useful for dynamic IPs.

Werner Hövelmanns CR 0 V 0 Easy +8 −0 updated 06/03/13, 20:49

Commit message

This is useful for dynamic IPs.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 5

  1. Steffen Gebert commented on patch set 1 01/01/12, 16:05

    Do not submit Hi Werner, thanks for your contribution. I appreciate your efforts. Besides violations to the Coding Guide Lines [1] (that's why Jenkins CI complains) you're doing things that I would not do. cmpIp is IMHO a function that compares IPs. Not IPs and hostnames. And introducing a nomenclature with the leading "=" is no good idea. As you did not motivate your changes, I can only assume that you want to enable host names in settings like devIPmask or similar? If this is the case, it would be nice, if you could create a patch for that code and call gethostbyname() after you checked that it's not a valid IP (with t3lib_div::validIP). This would be a nice addition. If you have more arguments for this particular change or sb. else sees a need for this, please come up with your arguments. Then I'm open to discuss removing my -2 vote. Otherwise, if you agree, Werner, please hit the "Abandon" button to close this change request. Again, thanks for your contribution - please continue! P.S: Please also follow the guide lines for Commit Messages [1] http://typo3.org/documentation/document-library/core-documentation/doc_core_cgl/current/ [2] http://wiki.typo3.org/CommitMessage_Format_(Git)
  2. Mr. Jenkins commented on patch set 1 01/01/12, 16:05

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2892/ : FAILURE
  3. Mr. Jenkins commented on patch set 2 01/01/12, 16:05

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2893/ : FAILURE
  4. Werner Hövelmanns uploaded patch set 2 01/01/12, 16:05

  5. Werner Hövelmanns commented on patch set 2 01/01/12, 16:05

    Abandoned I opened another request. Sorry