Review main Merged

76433[TASK] Separate file + folder creation controllers

Benni Mack CR +2 V +2 Hard +332 −197 updated 11/04/22, 13:51

Commit message

This change splits up the functionality of
the "CreateFolderController" into "add folder"
and "add file".

This also affects:
* Buttons in the file list module
* Actions in the Context Menu

which also uses more specific labels + icons.

This way, it is much clearer for editors on specific
actions. In addition, the code is split up
into CreateFileController and CreateFolderController.

Separate steps could be to also split up
the online media functionality into a modal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1524

  1. Benni Mack uploaded patch set 1 11/04/22, 11:24

  2. Benni Mack uploaded patch set 2 11/04/22, 11:29

  3. core-ci voted on patch set 1 V -1 11/04/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33102

  4. Benni Mack uploaded patch set 3 11/04/22, 11:37

  5. core-ci voted on patch set 2 V -1 11/04/22, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33103

  6. Benni Mack uploaded patch set 4 11/04/22, 11:45

  7. Benni Mack uploaded patch set 5 11/04/22, 11:49

  8. core-ci voted on patch set 3 V -1 11/04/22, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33104

  9. core-ci voted on patch set 5 V -1 11/04/22, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33108

  10. core-ci voted on patch set 4 V -1 11/04/22, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33107

  11. Benni Mack uploaded patch set 6 11/04/22, 12:13

  12. core-ci voted on patch set 6 V -1 11/04/22, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33109

  13. Benni Mack uploaded patch set 7 11/04/22, 12:38

  14. Oli Bartsch uploaded patch set 8 11/04/22, 12:49

  15. core-ci voted on patch set 7 V -1 11/04/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33113

  16. core-ci voted on patch set 8 V +1 11/04/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33117

  17. Oli Bartsch voted on patch set 8 V +1 CR +1 11/04/22, 13:24

  18. Andreas Kienast commented on patch set 8 CR -1 11/04/22, 13:32

    on it
  19. Andreas Kienast uploaded patch set 9 11/04/22, 13:33

  20. Andreas Kienast voted on patch set 9 V +1 CR +1 11/04/22, 13:35

  21. core-ci voted on patch set 9 V +1 11/04/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33121

  22. Stefan Bürk voted on patch set 9 V +1 CR +1 11/04/22, 13:41

  23. Oli Bartsch voted on patch set 9 V +2 CR +2 11/04/22, 13:51

  24. Oli Bartsch merged patch set 10 11/04/22, 13:51