7644[FEATURE]enable host names in settings like devIPmask This is useful for dynamic IPs. Change-Id: I935fadadabe77d1559538e7065459d42934114c2
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 13
-
Steffen Gebert commented on patch set 1 06/27/12, 06:08
Felix already explained the missing things in your commit message. It would be the best to start again after resetting your working tree (using `git reset --hard origin/master`). Then reapply your changes and put Change-Id: I935fadadabe77d1559538e7065459d42934114c2 into your commit message. -
Felix Kopp commented on patch set 1 06/27/12, 06:08
I would prefer that you didn't submit this That you for your work but this patch does not seem to be complete. Please see my inline comments for further description. Also your patch depends on an earlier patch of yours that was abandoned. Logically this current patch can never be commited. You could dive into the description to contribute at http://wiki.typo3.org/Contribution_Walkthrough It looks that you successfully set up your environment, please find further description there.Please write a short title. Further add a longer description after a empty line.You didn't put the target version of TYPO3 into the commit message. There should always be a line in your commit message like: "Releases: 4.7". Also please include the reference to an issue ticket on Forge (http://forge.typo3.org). Forge is the Issue-Tracker for all commits. Core patches are handled in the project "Core v4" at http://forge.typo3.org/projects/typo3v4-core. (see http://wiki.typo3.org/CommitMessage_Format_(Git) )class.t3lib_div.php:435I don't see a real difference here. Your code does not reflect the description in your commit message. Are you sure, that the complete code was commited? -
Mr. Jenkins commented on patch set 1 06/27/12, 06:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2894/ : SUCCESS -
Oliver Klee commented on patch set 2 06/27/12, 06:08
I would prefer that you didn't submit this We also need the issue ID in the commit message. -
Oliver Klee commented on patch set 2 06/27/12, 06:08
(1 inline comment) -
Helmut Hummel commented on patch set 2 06/27/12, 06:08
Do not submit I strongly recommend to not implement this feature because it adds one (or more?) additional DNS request(s) to each page request. Depending on the DNS Server quality this can slow down the page significantly! -
Steffen Gebert commented on patch set 2 06/27/12, 06:08
I would prefer that you didn't submit this Werner, I though we agreed on that the change should go to the function that evaluates devIPmask and not to cmpIP (which should compare IPs!). So it would be nice, if you could move that code to that point. I just looked it up and found that we have several places with this line: t3lib_div::cmpIP(t3lib_div::getIndpEnv('REMOTE_ADDR'), $GLOBALS['TYPO3_CONF_VARS']['SYS']['devIPmask'])) So I'm in favor of creating a new function (e.g. isIpInDevIpMask()), which is called on all of these places and also does the job of resolving host names). Could you do that, Werner? -
Steffen Gebert commented on patch set 2 06/27/12, 06:08
Yes, it depends on where this function is used. I would be fine to resolve DNS name when error handler is triggered. That's why it's a no-go in cmpIP(), because this one is probably called way more often. -
Felix Kopp commented on patch set 2 06/27/12, 06:08
I think this patch set should be abandoned. Please abandon with the "Abondon" button in this patch set. -
Mr. Jenkins commented on patch set 2 06/27/12, 06:08
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2895/ : FAILURE -
Werner Hövelmanns uploaded patch set 2 06/27/12, 06:08
-
Werner Hövelmanns commented on patch set 2 06/27/12, 06:08
Ok, I will do so. -
Werner Hövelmanns commented on patch set 2 06/27/12, 06:08
Abandoned