Review 11.5 Merged

76448[BUGFIX] Clean up TCA Tree code base

Oli Bartsch CR +2 V +2 Normal +27 −52 updated 11/06/22, 10:45

Commit message

This change simplifies further
work on the TCA Tree logic.

a) use imported names
b) ensure to use int|string for Node->getId() as Core uses this
   for integers within e.g. sys_category
c) fix some phpdoc infos
d) remove an unused property
e) use proper casting for integers
f) use $this->lookupField instead of $this->getLookupField()
   when using 10000 of categories, this function call is superfluous.

By using int|string, the changed code

  if ($node->getId() !== 0 && $node->getId() !== '0')

saves 1 (!) DB query on every request.

This change is meant also to be backported
to v11, for this reason no changes to the types within properties are
made (only type hints).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5