76462[FEATURE] Allow glob patterns in yaml imports
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+11 −3
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-93112-AllowGlobPatternsInYamlImports.rst2new+34 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/Glob/01_ImportedFile.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/Glob/02_ImportedFile.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/LoadWithGlobbedImports.yamlnew+7 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/LoadWithGlobbedImportsWithPathTraversal.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php2+47 −0
Review log 1926
Show 1 earlier messages
-
Susi Moog uploaded patch set 1 11/07/22, 22:32
-
core-ci voted on patch set 1 V -1 11/08/22, 00:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33233
-
Susi Moog uploaded patch set 2 11/08/22, 10:03
-
core-ci voted on patch set 2 V -1 11/08/22, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33285
-
Susi Moog uploaded patch set 3 11/08/22, 13:51
-
Susi Moog uploaded patch set 4 11/08/22, 13:54
-
Christian Kuhn commented on patch set 4 11/08/22, 13:57
This change is ready for review.YamlFileLoaderTest.php:172please turn into functional test. -
Christian Kuhn commented on patch set 4 11/08/22, 13:59
not fully sure here: This adds "yet another" way of path traversal - we have similar things in TS @import and probably at various other places. Maybe we'd want to streamline similar places? -
Christian Kuhn commented on patch set 4 CR -1 11/08/22, 14:00
-1 due to the mocking unit test which should be a functional test. -
core-ci voted on patch set 3 V -1 11/08/22, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33316
-
core-ci voted on patch set 4 V +1 11/08/22, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33317
-
Susi Moog commented on patch set 4 11/08/22, 14:18
Reply
hm, don't really know how TS imports are similar here - do you intend to build a global loader component with multi format support? (similar to the various ways of Symfony config loading we could implement something like that with interfaces and multi-loader-chains, that would be a bit much for this feature I guess).Reply
Was a unit test to be in line with the other tests for this class using the same methodology (mocking file access) - I can look into doing a pre-patch rewriting the whole test class to functionals. -
Susi Moog commented on patch set 4 CR -1 11/08/22, 18:21
pre patch should be merged first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76490 -
Susi Moog uploaded patch set 5 11/09/22, 08:14
-
core-ci voted on patch set 5 V +1 11/09/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33374
-
Susi Moog commented on patch set 5 11/09/22, 08:26
YamlFileLoaderTest.php:172ReplyDone -
Benni Mack commented on patch set 5 11/09/22, 08:56
Feature-93112-AllowGlobPatternsInYamlImports.rst:16"compacter" is wrong, it's "more compact" -
Susi Moog commented on patch set 6 11/09/22, 08:58
Published edit on patch set 5. -
Susi Moog commented on patch set 6 11/09/22, 08:58
Feature-93112-AllowGlobPatternsInYamlImports.rst:16ReplyDone -
core-ci voted on patch set 6 V +1 11/09/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33381
-
Christian Kuhn commented on patch set 6 11/09/22, 09:27
Reply
well, we have multiple path traversal places in the core and they. having one more means yet another syntax to learn.Reply
ah. that's much better. thank you!YamlFileLoaderTest.php:216path traversal is always an issue when doing such things. should we make sure '.' and '..' are disallowed, so something like 'foo/../../../../etc/passwd' is denied by having some test? -
Susi Moog uploaded patch set 7 11/09/22, 10:43
-
core-ci voted on patch set 7 V +1 11/09/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33392
-
Christian Kuhn commented on patch set 7 V +1 CR +1 11/09/22, 10:51
YamlFileLoaderTest.php:216ReplyDone -
Benni Mack voted on patch set 7 V +2 CR +2 11/09/22, 12:49
-
Benni Mack merged patch set 8 11/09/22, 12:49