76464[BUGFIX] Ensure best matching URL is used during site resolving
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Susi Moog +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2633
Show 48 earlier messages
-
Oliver Hader uploaded patch set 1 11/07/22, 22:48
-
core-ci voted on patch set 1 V -1 11/07/22, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33267
-
Oliver Hader uploaded patch set 2 11/08/22, 13:36
-
core-ci voted on patch set 2 V -1 11/08/22, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33313
-
core-ci voted on patch set 2 V +1 11/08/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33313
-
Oliver Hader uploaded patch set 3 11/08/22, 14:41
-
Oliver Hader commented on patch set 3 11/08/22, 14:41
This change is ready for review. -
core-ci voted on patch set 3 V +1 11/08/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33319
-
Oliver Hader marked it work in progress 11/08/22, 14:52
-
Oliver Hader uploaded patch set 4 11/08/22, 17:54
-
core-ci voted on patch set 4 V -1 11/08/22, 18:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33331
-
Oliver Hader uploaded patch set 5 11/08/22, 18:31
-
core-ci voted on patch set 5 V +1 11/08/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33340
-
Oliver Hader commented on patch set 5 11/08/22, 18:48
This change is ready for review. -
Susi Moog voted on patch set 5 V +1 CR +1 11/08/22, 19:32
-
Benni Mack commented on patch set 5 11/08/22, 19:58
BestUrlMatcher.php:57no yoda style please -
Benni Mack commented on patch set 5 CR -2 11/08/22, 19:58
this can't go in until my comments are fixed!!!! -
Benni Mack voted on patch set 5 CR 0 11/08/22, 19:59
-
Benni Mack commented on patch set 5 11/08/22, 20:01
SiteMatcherTest.php:112comment is wrong now, I guess -
Benni Mack commented on patch set 5 CR -2 11/08/22, 20:01
I do have to re-add my veto here. -
Benni Mack voted on patch set 5 CR 0 11/08/22, 20:02
-
Oliver Hader marked it work in progress 11/08/22, 20:02
-
Oliver Hader commented on patch set 5 11/08/22, 20:02
Will check tomorrow -
Benni Mack uploaded patch set 6 11/08/22, 21:08
-
Benni Mack marked it ready for review 11/08/22, 21:09
-
Benni Mack voted on patch set 6 V +1 CR +1 11/08/22, 21:09
-
Benni Mack commented on patch set 6 11/08/22, 21:10
Looks good from my side now. -
Susi Moog voted on patch set 6 V +1 CR +1 11/08/22, 21:15
-
core-ci voted on patch set 6 V +1 11/08/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33357
-
Oliver Hader commented on patch set 6 11/08/22, 21:19
BestUrlMatcher.php:57ReplyDoneSiteMatcherTest.php:112ReplyDone -
Oliver Hader commented on patch set 6 11/08/22, 21:20
SiteMatcherTest.php:112it's the fallback route (having the same option) - which is kind of "random" -
Oliver Hader voted on patch set 6 V +2 CR +2 11/08/22, 21:21
-
Oliver Hader merged patch set 7 11/08/22, 21:21