Review main Merged

76466[BUGFIX] Fix PHP warning in RTE parseFunc option prefixRelPathWith

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/08/22, 10:32

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 11/07/22, 22:58

  2. core-ci voted on patch set 1 V +1 11/07/22, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33269

  3. Oliver Klee voted on patch set 1 CR +1 11/08/22, 08:15

  4. Christian Kuhn voted on patch set 1 CR +1 11/08/22, 08:20

  5. Stefan Bürk commented on patch set 1 11/08/22, 08:45

    HtmlParser.php:564

    As we are on it, should we not replace this array access on a string with a proper "str_starts_with()" ?
  6. Benni Mack commented on patch set 2 11/08/22, 10:13

    Published edit on patch set 1.
  7. Christian Kuhn commented on patch set 2 V +1 CR +1 11/08/22, 10:24

    HtmlParser.php:564 Reply

    Done
  8. core-ci voted on patch set 2 V +1 11/08/22, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33286

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 11/08/22, 10:32

  10. Stefan Bürk merged patch set 3 11/08/22, 10:32