Review main Merged

76481[BUGFIX] Ensure proper encapsulation of comparisons with QueryBuilder

Stefan Bürk CR +2 V +2 Hard +225 −66 updated 11/09/22, 08:55

Commit message

When using a TCA table without deleted, or any other enablefields
except "endtime", then the SQL query is built in a wrong fashion
both in PageRepository and BackendUtility. Thee source of this disaster
is inproper encapsulation in parenthesis when comparisons are build.

Instead of simply adding a manual "()" around the or() comparisons,
this change adjusts CompositionExpresion to properly add corresponding
parenthesis, which ensure this in every case and avoid missing usages.

A couple of tests are adjusted to properly reflect this change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15