Review main Merged

76490[TASK] Rewrite YamlLoaderTests as functional tests

Susi Moog CR +2 V +2 Hard +262 −299 updated 11/08/22, 20:04

Commit message

The YamlLoaderTests are better suited as functional tests
as they access the file system and require accessible mocks
otherwise.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1115

  1. Susi Moog uploaded patch set 1 11/08/22, 17:49

  2. Susi Moog uploaded patch set 2 11/08/22, 17:54

  3. core-ci voted on patch set 1 V +1 11/08/22, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33328

  4. core-ci voted on patch set 2 V +1 11/08/22, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33332

  5. Susi Moog updated the commit message in patch set 3 11/08/22, 18:21

  6. core-ci voted on patch set 3 V +1 11/08/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33339

  7. Susi Moog marked it ready for review 11/08/22, 18:30

  8. Oliver Hader voted on patch set 3 CR +1 11/08/22, 19:04

  9. Oliver Hader voted on patch set 3 V +1 11/08/22, 19:05

  10. Stefan Bürk commented on patch set 3 CR -1 11/08/22, 19:43

    on it ...
  11. Stefan Bürk uploaded patch set 4 11/08/22, 19:45

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 11/08/22, 19:54

  13. core-ci voted on patch set 4 V +1 11/08/22, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33348

  14. Oliver Hader voted on patch set 4 V +2 CR +2 11/08/22, 20:04

  15. Oliver Hader merged patch set 5 11/08/22, 20:04