Review 11.5 Merged

76498[TASK] Update to PHPStan 1.9.2

Oliver Klee CR +2 V +2 Easy +9 −9 updated 11/10/22, 12:05

Commit message

This update makes a warning more specific.

Run commands:

> composer req --dev phpstan/phpstan:^1.9.2
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Klee commented on patch set 1 11/10/22, 11:37

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.lock
  2. Oliver Klee uploaded patch set 2 11/10/22, 11:40

  3. Oliver Klee marked it ready for review 11/10/22, 11:40

  4. core-ci voted on patch set 1 V -1 11/10/22, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33464

  5. core-ci voted on patch set 2 V +1 11/10/22, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33466

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/22, 12:05

  7. Christian Kuhn merged patch set 3 11/10/22, 12:05