Review 11.5 Merged

76513[BUGFIX] Ensure best matching URL is used during site resolving

Oliver Hader CR +2 V +2 Hard +331 −44 updated 11/09/22, 09:21

Commit message

Symfony's UrlMatcher takes multiple routes and returns the first
match. However there might be better matches that are not considered
at all. That's why a custom BestUrlMatcher is introduce, which
resolves all matches for further reduction.

Previously the route collection was sorted by names and identifiers,
which now has been adjusted to focus on the actual matches when being
compared to the current request. The fallback route (site base URI).
This way, overlapping route definitions can be resolved better.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 58

  1. Oliver Hader uploaded patch set 1 11/08/22, 21:25

  2. core-ci voted on patch set 1 V -1 11/08/22, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33358

  3. Oliver Hader uploaded patch set 2 11/09/22, 08:37

  4. core-ci voted on patch set 2 V -1 11/09/22, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33376

  5. Oliver Hader uploaded patch set 3 11/09/22, 09:02

  6. core-ci voted on patch set 3 V +1 11/09/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33382

  7. Oliver Hader voted on patch set 3 V +2 CR +2 11/09/22, 09:21

  8. Oliver Hader merged patch set 4 11/09/22, 09:21