Review main Merged

76520[FEATURE] Introduce Site Settings Read API

Benni Mack CR +2 V +2 Normal +186 −46 updated 11/10/22, 15:45

Commit message

When using site configuration with
settings, they previously were accessible
via $site->getConfiguration()['settings'].

A site now also contains the settings
in a better way to read them via $site->getSettings()
where a SiteSettings object is resolved,
which contains all defined settings.

Settings can be defined in a settings.yaml
within the site configuration folder, which
are then read and populated along with
the site configuration.

The new SiteSettings Read API allows to access
the settings via a flat array or a full array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1420

  1. Benni Mack uploaded patch set 1 11/09/22, 13:47

  2. core-ci voted on patch set 1 V -1 11/09/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33401

  3. Benni Mack uploaded patch set 2 11/09/22, 14:22

  4. core-ci voted on patch set 2 V -1 11/09/22, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33402

  5. Benni Mack uploaded patch set 3 11/10/22, 11:45

  6. Benni Mack uploaded patch set 4 11/10/22, 12:04

  7. core-ci voted on patch set 3 V -1 11/10/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33469

  8. Susi Moog voted on patch set 4 CR +1 11/10/22, 12:14

  9. Susi Moog voted on patch set 4 V +1 11/10/22, 12:21

  10. Georg Ringer commented on patch set 4 11/10/22, 12:29

    should we make that also available just as https://review.typo3.org/c/Packages/TYPO3.CMS/+/58434/
  11. core-ci voted on patch set 4 V -1 11/10/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33477

  12. Benni Mack uploaded patch set 5 11/10/22, 13:05

  13. core-ci voted on patch set 5 V -1 11/10/22, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33491

  14. Georg Ringer voted on patch set 5 CR +1 11/10/22, 13:19

  15. Susi Moog uploaded patch set 6 11/10/22, 14:56

  16. core-ci voted on patch set 6 V +1 11/10/22, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33501

  17. Susi Moog voted on patch set 6 V +1 CR +1 11/10/22, 15:31

  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 11/10/22, 15:43

  19. Benni Mack voted on patch set 6 V +2 CR +2 11/10/22, 15:45

  20. Benni Mack merged patch set 7 11/10/22, 15:45