Review main Merged

76525[BUGFIX] Get the correct next stage for moved elements in workspace

Tim Horstmann CR +2 V +2 Easy +1 −1 updated 02/15/23, 15:58

Commit message

The method TYPO3\CMS\Workspaces\Service\StageService->getNextStageForElementCollection relies on the field t3ver_stage to calculate the next stage for changed elements in a workspace. Without it, it falls back to 0 (zero), meaning the current stage is "Editing". This fix provides the neccessary field so the next stage can be calculated correct.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Tim Horstmann uploaded patch set 1 11/09/22, 16:48

  2. core-ci voted on patch set 1 V +1 11/09/22, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33417

  3. Benni Mack voted on patch set 1 CR +1 11/10/22, 07:40

  4. Georg Ringer voted on patch set 1 CR +1 11/10/22, 08:13

  5. Josua Vogel voted on patch set 1 CR +1 11/10/22, 08:20

  6. Benni Mack voted on patch set 1 V +1 12/21/22, 16:34

  7. Josua Vogel voted on patch set 1 V +1 02/15/23, 09:50

  8. Oli Bartsch voted on patch set 1 V +2 CR +2 02/15/23, 15:58

  9. Oli Bartsch merged patch set 2 02/15/23, 15:58