Review main Merged

76536[BUGFIX] Rebuild redirect cache also for new records

Achim Fritz CR +2 V +2 Easy +1 −1 updated 11/10/22, 20:51

Commit message

EXT:redirects DataHandler hook to flush the redirects cache in
case a redirect is modified does now also work for new redirect
records by removing parts of the early return, which relied on
records having a numeric uid while new records' uid is the known
"NEW.*" string.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Achim Fritz uploaded patch set 1 11/10/22, 10:44

  2. core-ci voted on patch set 1 V +1 11/10/22, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33455

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 11/10/22, 11:53

  4. Oli Bartsch commented on patch set 1 CR -1 11/10/22, 11:57

    I'm missing some description about what this patch actually does, why and how.
  5. Achim Fritz uploaded patch set 2 11/10/22, 12:20

  6. core-ci voted on patch set 2 V +1 11/10/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33487

  7. Oli Bartsch updated the commit message in patch set 3 11/10/22, 19:24

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 11/10/22, 19:25

  9. Susi Moog voted on patch set 3 V +1 CR +1 11/10/22, 19:29

  10. core-ci voted on patch set 3 V +1 11/10/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33528

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 11/10/22, 20:51

  12. Stefan Bürk merged patch set 4 11/10/22, 20:51