76599[TASK] Add default value for method in FormViewHelper
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Sybille Peters uploaded patch set 1 11/14/22, 17:53
-
core-ci voted on patch set 1 V -1 11/14/22, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33723
-
Benni Mack commented on patch set 1 11/23/22, 16:51
Hey Sybille - Care to update the patch and fix the failing tests? -
Chris Müller commented on patch set 1 11/23/22, 18:46
FormViewHelper.php:133The method is mostly written in uppercase (like in the description), so this should be "POST" instead of "post". -
Sybille Peters uploaded patch set 2
V -103/05/23, 16:01 -
core-ci voted on patch set 2 V +1 03/05/23, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38497
-
Christian Kuhn uploaded patch set 3
V +103/21/23, 13:54 -
Christian Kuhn commented on patch set 3 03/21/23, 13:56
FormViewHelper.php:133Replyit does not matter much, we're now going with lowercase, since html attribute values are usually lowercase. -
core-ci voted on patch set 3 V +1 03/21/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39324
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/21/23, 14:47
-
Stefan Bürk voted on patch set 3 V +2 CR +2 03/21/23, 15:11
-
Stefan Bürk merged patch set 4 03/21/23, 15:11
-
Sybille Peters commented on patch set 4 03/22/23, 05:52
Thanks guys! The default is now displayed in the VH ref: https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/Form.html#method (mission accomplished)