Review main Merged

76605[FEATURE] Allow static backdrops for modals

Andreas Kienast CR +2 V +2 Normal +65 −5 updated 11/16/22, 07:21

Commit message

The Modal API is now able to render a static backdrop to avoid closing
the modal when clicking it which may come in handy in case closing the
modal would result in a negative user experience, e.g. in the image
cropper.

The new boolean configuration option `staticBackdrop` controls whether
a static backdrop should be rendered or not, defaulting to `false`.

The trigger class "t3js-modal-trigger" also supports the new option
by setting corresponding data attribute.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1015

  1. Andreas Kienast uploaded patch set 1 11/15/22, 10:52

  2. Andreas Kienast uploaded patch set 2 11/15/22, 10:54

  3. core-ci voted on patch set 2 V +1 11/15/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33746

  4. core-ci voted on patch set 1 V +1 11/15/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33745

  5. Andreas Kienast updated the commit message in patch set 3 11/15/22, 12:53

  6. Benni Mack voted on patch set 3 CR +1 11/15/22, 13:00

  7. core-ci voted on patch set 3 V -1 11/15/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33753

  8. core-ci voted on patch set 3 V +1 11/15/22, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33753

  9. Oli Bartsch commented on patch set 3 11/16/22, 00:49

    modal.ts:467

    Could we please make the new option also available for usage of the "old" markup trigger "t3js-modal-trigger"?
  10. Oli Bartsch uploaded patch set 4 11/16/22, 01:10

  11. Oli Bartsch commented on patch set 4 V +1 CR +1 11/16/22, 01:10

    modal.ts:467 Reply

    Done
  12. core-ci voted on patch set 4 V +1 11/16/22, 01:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33788

  13. Benni Mack voted on patch set 4 V +1 CR +1 11/16/22, 07:20

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 11/16/22, 07:21

  15. Andreas Kienast merged patch set 5 11/16/22, 07:21