Review main Abandoned

76606[WIP][BUGFIX] addQueryString.exclude overrides config.linkVars

Benni Mack CR 0 V 0 Easy +9 −11 updated 12/12/24, 09:02

Commit message

If you use config.linkVars = benni=1 but create
a link via Typolink like

10 = TEXT
10.typolink.parameter = 13
10.typolink.addQueryString = 1
10.typolink.addQueryString.exclude = benni

then addQueryString now also removes values
set efrom config.linkVars.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Benni Mack uploaded patch set 1 11/15/22, 12:23

  2. core-ci voted on patch set 1 V +1 11/15/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33749

  3. Benni Mack commented on patch set 1 CR -1 11/15/22, 13:02

    wrong approach :(
  4. Benni Mack uploaded patch set 2 11/15/22, 13:21

  5. core-ci voted on patch set 2 V -1 11/15/22, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33755

  6. Benni Mack abandoned the change 12/12/24, 09:02