76637[TASK] Replace static property caches in RootlineUtility
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+3 −2
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+3 −2
- typo3/sysext/core/Classes/Utility/RootlineUtility.php5+27 −38
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+0 −6
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+1 −1
- composer.lock+4 −4
Review log 1826
Show 1 earlier messages
-
Stefan Bürk uploaded patch set 1 11/16/22, 01:21
-
core-ci voted on patch set 1 V +1 11/16/22, 01:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33789
-
Stefan Bürk uploaded patch set 2 11/16/22, 01:38
-
core-ci voted on patch set 2 V +1 11/16/22, 02:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33790
-
Stefan Bürk uploaded patch set 3 11/16/22, 02:30
-
core-ci voted on patch set 3 V +1 11/16/22, 02:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33793
-
Stefan Bürk uploaded patch set 4 11/16/22, 02:59
-
core-ci voted on patch set 4 V +1 11/16/22, 03:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33794
-
Stefan Bürk uploaded patch set 5 11/16/22, 03:54
-
core-ci voted on patch set 5 V -1 11/16/22, 04:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33796
-
Stefan Bürk uploaded patch set 6 11/16/22, 04:06
-
core-ci voted on patch set 6 V +1 11/16/22, 04:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33799
-
Christian Kuhn commented on patch set 6 11/16/22, 15:49
-
Stefan Bürk commented on patch set 6 11/16/22, 17:16
RootlineUtility.php:161ReplyFirst implementation was without tag. But after core classes used the old purgeCaches() to clear explicitly only the RootlineUtility caches, I thought it *might* be code to differenciate it using tags. See for example https://review.typo3.org/c/Packages/TYPO3.CMS/+/76637/6/typo3/sysext/core/Classes/DataHandling/SlugHelper.php#b370 or https://review.typo3.org/c/Packages/TYPO3.CMS/+/76637/6/typo3/sysext/core/Classes/Routing/SiteMatcher.php#b76 Thus I'm not really sure about this. -
Christian Kuhn commented on patch set 6 11/16/22, 17:51
RootlineUtility.php:161Replyi see. thx. mmh. need to give this some thaught. -
Stefan Bürk commented on patch set 6 11/16/22, 18:03
RootlineUtility.php:161ReplySure, take your time. -
Christian Kuhn commented on patch set 6 11/17/22, 07:43
RootlineUtility.php:161Replyyou're right. the usages indicate we should be able to flush by tag, that's the safer bet. let's reduce to one tag, though and mark the constant internal. -
Christian Kuhn uploaded patch set 7 11/17/22, 07:48
-
Christian Kuhn updated the commit message in patch set 8 11/17/22, 07:49
-
core-ci voted on patch set 8 V +1 11/17/22, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33842
-
core-ci voted on patch set 7 V +1 11/17/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33841
-
Christian Kuhn voted on patch set 8 V +1 CR +1 11/17/22, 08:07
-
Benni Mack commented on patch set 8 11/17/22, 08:46
very nice one. In the future, I hope to have a 2-level cache in our CF, so we can get rid of the explicit runtime cache flushing. -
Benni Mack voted on patch set 8 V +1 CR +1 11/17/22, 08:46
-
Stefan Bürk voted on patch set 8 V +2 CR +2 11/17/22, 08:57
-
Stefan Bürk merged patch set 9 11/17/22, 08:57
RootlineUtility.php:161