Review 11.5 Merged

76653[TASK] Annotate ActionController methods that never return

Oliver Klee CR +2 V +2 Easy +4 −5 updated 11/17/22, 09:22

Commit message

Extbase controllers that call a never-returning method do not
need a return statement after that call in order to avoid
calling the rest of the action method. The new annotations
ensure that PHPStan becomes aware of this control flow.

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2