Review main Merged

76654[TASK] Make the action name in ActionController::redirect() nullable

Oliver Klee CR +2 V +2 Easy +1 −1 updated 11/17/22, 18:04

Commit message

Passing no action name is a perfectly fine use case as this allows
to conveniently redirect from a controller action to any page.

Making this explicit in the type annotations allows extension authors
to use this pattern without type checkers like PHPStan creating a
warnings about this.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1