Review main Merged

76656[TASK] Remove a heavy-mocking unit test

Christian Kuhn CR +2 V +2 Easy +0 −48 updated 11/17/22, 09:00

Commit message

getPagesTSconfigWorksWithoutInitializedBackendUser()
does nothing insanely useful and is more a burden
than a helper when the implementation of the
test subject is changed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 11/17/22, 08:30

  2. Christian Kuhn uploaded patch set 2 11/17/22, 08:31

  3. Benni Mack voted on patch set 2 V +1 CR +1 11/17/22, 08:36

  4. Oliver Klee voted on patch set 2 V +1 CR +1 11/17/22, 08:42

  5. core-ci voted on patch set 1 V -1 11/17/22, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33851

  6. core-ci voted on patch set 2 V +1 11/17/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33852

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 11/17/22, 09:00

  8. Christian Kuhn merged patch set 3 11/17/22, 09:00