Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

76662[FEATURE] Introduce global routes

Susi Moog CR 0 V 0 Hard +263 −1 updated 04/11/25, 16:35

Commit message

Allow configuration of global (page-independent) routes
based on Symfony routing.

composer command:

 `composer req symfony/psr-http-message-bridge:^7.0`

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 16
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/76662/16 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/76662/16 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 6

Review log 2945

Show 1220 earlier messages
  1. Susi Moog uploaded patch set 1 11/17/22, 10:00

  2. Susi Moog updated the commit message in patch set 2 11/17/22, 10:02

  3. core-ci voted on patch set 1 V -1 11/17/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33861

  4. core-ci voted on patch set 2 V -1 11/17/22, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33862

  5. Susi Moog uploaded patch set 3 V -1 01/06/23, 13:03

  6. core-ci voted on patch set 3 V -1 01/06/23, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35534

  7. Oliver Hader voted on patch set 3 CR +1 01/18/23, 16:34

  8. Susi Moog uploaded patch set 4 CR +1 V -1 03/01/23, 16:38

  9. Susi Moog uploaded patch set 5 03/01/23, 17:10

  10. Susi Moog marked it ready for review 03/01/23, 17:11

  11. core-ci voted on patch set 4 V -1 03/01/23, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38269

  12. core-ci voted on patch set 5 V -1 03/01/23, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38270

  13. Susi Moog commented on patch set 6 V -1 03/02/23, 06:58

    Published edit on patch set 5.
  14. core-ci voted on patch set 6 V -1 03/02/23, 07:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38287

  15. Susi Moog commented on patch set 7 V -1 03/02/23, 07:37

    Published edit on patch set 6.
  16. core-ci voted on patch set 7 V -1 03/02/23, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38290

  17. Susi Moog commented on patch set 8 V -1 03/02/23, 08:03

    Published edit on patch set 7.
  18. Daniel Goerz commented on patch set 7 03/02/23, 08:04

    I like the approach. Thanks for digging this one up. 👍
  19. core-ci voted on patch set 8 V +1 03/02/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38292

  20. Georg Ringer commented on patch set 8 03/02/23, 08:15

    Feature-89518-GlobalRouting.rst:36 Unresolved

    It would be awesome to have also an example of the controller because otherwise someone will just try an extbase based controller and it won't work
  1. Georg Ringer uploaded patch set 9 V +1 03/03/23, 08:45

  2. Georg Ringer voted on patch set 9 V +1 CR +1 03/03/23, 08:45

  3. core-ci voted on patch set 9 V +1 03/03/23, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38346

  4. Chris Müller uploaded patch set 10 CR +1 V +1 03/03/23, 13:11

  5. core-ci voted on patch set 10 V +1 03/03/23, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38359

  6. Christian Eßl uploaded patch set 11 V +1 03/20/23, 15:59

  7. core-ci voted on patch set 11 V -1 03/20/23, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39257

  8. Christian Eßl uploaded patch set 12 V -1 03/20/23, 16:04

  9. core-ci voted on patch set 12 V -1 03/20/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39258

  10. Christian Eßl uploaded patch set 13 V -1 03/20/23, 17:04

  11. core-ci voted on patch set 13 V +1 03/20/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39262

  12. Georg Ringer voted on patch set 13 V +1 CR +1 03/20/23, 18:10

  13. Georg Ringer uploaded patch set 14 CR +1 V +1 03/20/23, 18:11

  14. Georg Ringer voted on patch set 14 V +1 CR +1 03/20/23, 18:12

  15. core-ci voted on patch set 14 V +1 03/20/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39268

  16. Guido Schmechel commented on patch set 14 03/20/23, 20:46

    The positive case worked. Controller with parameters everything wonderful. I then removed GET from the list of methods as a test and get an error. Does it make sense to react to this? It's a classic 500 http request for now. Does it make sense to catch the exception Symfony\Component\Routing\Exception\MethodNotAllowedException and send a status code 405?
  17. Benni Mack commented on patch set 14 CR -1 03/20/23, 21:42

    I think we need to consider if we want to enable this globally AND (or just OR) on a per-site basis.

    GlobalRouteResolver.php:47

    needs to be cached.
  18. Stefan Bürk commented on patch set 14 03/23/23, 01:12

    Reply

    TBH reading "global routes" I would not expect that they are "resolved site" related. I had to read carefully, that "global" means "globally" defined, but "resolved site based" matching should be done. From that perspectice, I could thing about splitting it up: * doing this really global before site resolving (removing site based matching) * adding a per site-config based "dynamic" route definitions like per site "static route" configuration in a dedicated change/feature. or * rephrase/rename this so it's not called "global" routes which describes it a little bit more clearer to the audiance. With the first suggestion, instances with dozen of sites could still fine-tune this per site instead and still can have global ones in some way .. Or a global file + site configuratio merged and doing it at this point ? I guess we should carefully think what we really want to implement here.

    GlobalRouteResolver.php:47 Reply Unresolved

    absolutly ack. I would further suggest, that the "loading"/parsing should be moved in kind of a service - so it can also be added to system `cache:warmup` command.
  19. Hannes Lau commented on patch set 14 08/05/23, 09:56

    Thank your for this patch! I really like the idea that there is a more standardised way for developers to offer APIs!

    Reply Unresolved

    I think it would be great to have both (globally AND per-site), but per-site now seems more important to me. You can still archive "global" APIs by exposing them on every site. Site-specific routes could be integrated into the site config.
  20. Simon Schaufelberger uploaded patch set 15 CR +1 V +1 04/22/24, 17:58

  21. core-ci voted on patch set 15 V -1 04/22/24, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56506

  22. Georg Ringer uploaded patch set 16 V -1 04/22/24, 19:07

  23. core-ci voted on patch set 16 V +1 04/22/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56508

  24. Benni Mack marked it work in progress 04/11/25, 16:35

  25. Benni Mack commented on patch set 16 04/11/25, 16:35

    I move this to WIP, seems progress has been stalled the past 1.5 years