Review main Merged

76666[TASK] Replace prophecy in EXT:core/Tests/Unit/Database/*

Torben Hansen CR +2 V +2 Expert +425 −658 updated 11/17/22, 21:31

Commit message

Note, that the combination of shouldBeCalled and shouldNotBeCalled
for the `quoteIdentifier` function in `QueryBuilderTest` has
been replaced with the `never` expectation only, since the tests
only test, if the star placeholder is not quoted.

Also 2 new mock classes have been introduced to cover the tests
in `AbstractRestrictionContainerTest`, where the mock object
must implement 2 interfaces, which is not mockable.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 13

Files 15