Review main Merged

76704[TASK] Modernize ext:adminpanel

Christian Kuhn CR +2 V +2 Hard +110 −234 updated 11/19/22, 15:42

Commit message

* Use more DI
* Avoid MainController being a singleton, have it DI shared
* Avoid static state in InMemoryLogWriter
* Add various type hints
* Streamline annotations
* Avoid a useless exception class
* Use inject* method for DI in an abstract class to avoid
  polluting __construct() for consumers.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 26

Show 6 more files