76742[TASK] Fix some phpstan errors
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 27
- Build/phpstan/phpstan-baseline.neon+0 −110
- typo3/sysext/core/Classes/Cache/Frontend/NullFrontend.php+2 −1
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/AbstractArgon2PasswordHash.php+2 −8
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.php+1 −4
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.php+1 −7
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Md5PasswordHash.php+1 −7
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashInterface.php+3 −3
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Pbkdf2PasswordHash.php+1 −7
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PhpassPasswordHash.php+1 −7
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/PhpError.php+2 −11
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+42 −54
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+4 −10
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/Fixtures/Crypto/PasswordHashing/NoopPasswordHash.php2+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/Fixtures/ConcreteBackendFixture.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/BackendFixture.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/FrontendFixture.php4+7 −1
Show 7 more files
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+1 −5
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+1 −4
- typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php+2 −4
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+4 −22
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+4 −3
Review log 1316
-
Christian Kuhn uploaded patch set 1 11/20/22, 14:06
-
Christian Kuhn updated the commit message in patch set 2 11/20/22, 14:13
-
core-ci voted on patch set 1 V +1 11/20/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34004
-
core-ci voted on patch set 2 V +1 11/20/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34005
-
Stefan Bürk voted on patch set 2 V +1 CR +1 11/20/22, 14:27
-
Oliver Klee commented on patch set 2 11/20/22, 14:54
FrontendFixture.php:39@return neverFrontendFixture.php:41Let's make the message more helpful: "This method is only there to implement the interface and must not be called." (or something similar) -
Oliver Klee voted on patch set 2 V +1 11/20/22, 14:54
-
Oliver Klee commented on patch set 2 11/20/22, 14:56
Could we also backport this to 11.5? -
Christian Kuhn commented on patch set 2 11/20/22, 15:03
Reply
no.NoopPasswordHash.php:52Replyno need. this method returns string only. that's fine to annotate.FrontendFixture.php:39ReplyDoneFrontendFixture.php:41ReplyDone -
Christian Kuhn uploaded patch set 3
CR +1V +111/20/22, 15:03 -
Oliver Klee voted on patch set 3 CR +1 11/20/22, 15:05
-
core-ci voted on patch set 3 V +1 11/20/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34009
-
Oliver Klee voted on patch set 3 V +1 11/20/22, 15:12
-
Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/22, 15:15
-
Stefan Bürk voted on patch set 3 V +2 CR +2 11/20/22, 15:15
-
Stefan Bürk merged patch set 4 11/20/22, 15:15
NoopPasswordHash.php:52