Review main Merged

76742[TASK] Fix some phpstan errors

Christian Kuhn CR +2 V +2 Hard +89 −277 updated 11/20/22, 15:15

Commit message

Most of these are from test related ignore patterns.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 1316

  1. Christian Kuhn uploaded patch set 1 11/20/22, 14:06

  2. Christian Kuhn updated the commit message in patch set 2 11/20/22, 14:13

  3. core-ci voted on patch set 1 V +1 11/20/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34004

  4. core-ci voted on patch set 2 V +1 11/20/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34005

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 11/20/22, 14:27

  6. Oliver Klee commented on patch set 2 11/20/22, 14:54

    NoopPasswordHash.php:52

    Shouldn't that be the nullable ?string (for consistency)?

    FrontendFixture.php:39

    @return never

    FrontendFixture.php:41

    Let's make the message more helpful: "This method is only there to implement the interface and must not be called." (or something similar)
  7. Oliver Klee voted on patch set 2 V +1 11/20/22, 14:54

  8. Oliver Klee commented on patch set 2 11/20/22, 14:56

    Could we also backport this to 11.5?
  9. Christian Kuhn commented on patch set 2 11/20/22, 15:03

    Reply

    no.

    NoopPasswordHash.php:52 Reply

    no need. this method returns string only. that's fine to annotate.

    FrontendFixture.php:39 Reply

    Done

    FrontendFixture.php:41 Reply

    Done
  10. Christian Kuhn uploaded patch set 3 CR +1 V +1 11/20/22, 15:03

  11. Oliver Klee voted on patch set 3 CR +1 11/20/22, 15:05

  12. core-ci voted on patch set 3 V +1 11/20/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34009

  13. Oliver Klee voted on patch set 3 V +1 11/20/22, 15:12

  14. Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/22, 15:15

  15. Stefan Bürk voted on patch set 3 V +2 CR +2 11/20/22, 15:15

  16. Stefan Bürk merged patch set 4 11/20/22, 15:15