Review main Merged

76746[TASK] Improve the type annotations around GU::makeInstance & friends

Oliver Klee CR +2 V +2 Normal +52 −61 updated 11/23/22, 15:46

Commit message

Run command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Oliver Klee uploaded patch set 1 11/20/22, 15:57

  2. core-ci voted on patch set 1 V +1 11/20/22, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34011

  3. Christian Kuhn updated the commit message in patch set 2 V +1 11/23/22, 15:36

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 11/23/22, 15:36

  5. core-ci voted on patch set 2 V +1 11/23/22, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34119

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 11/23/22, 15:46

  7. Stefan Bürk merged patch set 3 11/23/22, 15:46