Review main Merged

76754[TASK] Improve some type annotations in TypoScript-related classes

Oliver Klee CR +2 V +2 Easy +5 −2 updated 11/23/22, 15:40

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oliver Klee uploaded patch set 1 11/21/22, 08:30

  2. core-ci voted on patch set 1 V +1 11/21/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34028

  3. Stefan Bürk commented on patch set 1 CR -1 11/22/22, 23:25

    Can we please narrow this down to main only ? `typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php` is not available in v11 .. and both are internal only. So I would say there is no real urgend need for a backport at all. And not sure about the "mixed" in the AST once too. I would say, this should be reviewed by lolli at least. Thus -1 for now until lolli looked at this one.
  4. Christian Kuhn uploaded patch set 2 CR -1 V +1 11/23/22, 15:12

  5. Christian Kuhn commented on patch set 2 V +1 CR +1 11/23/22, 15:14

    Reply

    yep. skip v11.
  6. core-ci voted on patch set 2 V +1 11/23/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34116

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 11/23/22, 15:40

  8. Stefan Bürk merged patch set 3 11/23/22, 15:40