Review main Merged

76755[BUGFIX] Apply previous site identifier as fallback for URL resolving

Oliver Hader CR +2 V +2 Easy +15 −3 updated 04/22/23, 11:13

Commit message

Prior to #93240 URL routes were reverse sorted using the corresponding
site identifier (which did not contain any URL information). For the
scenario of matching undefined URLs (e.g. base URL is "/website/", but
request was like "https://example.org/"), the first item of a reverse
sorted list was used.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Oliver Hader uploaded patch set 1 11/21/22, 10:04

  2. core-ci voted on patch set 1 V -1 11/21/22, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34030

  3. Oliver Hader uploaded patch set 2 V -1 11/21/22, 10:17

  4. core-ci voted on patch set 2 V +1 11/21/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34031

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/22/22, 13:29

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 11/22/22, 23:10

  7. Benni Mack commented on patch set 2 03/24/23, 08:41

    Ping Olly.
  8. Oliver Hader commented on patch set 2 04/22/23, 11:08

    Why did nobody merge this, yet?!
  9. Oliver Hader voted on patch set 2 V +2 CR +2 04/22/23, 11:13

  10. Oliver Hader merged patch set 3 04/22/23, 11:13