76756[BUGFIX] Prevent PHP 8.1 runtime deprecation notice in IconRegistry
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Nikita Hovratov uploaded patch set 1 11/21/22, 11:15
-
core-ci voted on patch set 1 V +1 11/21/22, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34033
-
Oliver Klee voted on patch set 1 V +1 CR +1 11/21/22, 11:28
-
Oliver Klee commented on patch set 1 V 0 CR -1 11/21/22, 11:29
This also affects main, and we should fix it there first. -
Nikita Hovratov updated the commit message in patch set 2
CR -1V +111/21/22, 11:40 -
Nikita Hovratov commented on patch set 2 11/21/22, 11:41
Reply
Yes, you're right. Eventhough the causing code part in core doesn't exist anymore, it should be fixed for custom code. -
Oliver Klee voted on patch set 2 CR +1 11/21/22, 11:41
-
Nikita Hovratov commented on patch set 2 11/21/22, 11:41
Reply
Done -
Oliver Klee commented on patch set 2 11/21/22, 11:42
Reply
Done -
core-ci voted on patch set 2 V +1 11/21/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34035
-
Oliver Klee voted on patch set 2 V +1 11/21/22, 12:00
-
Benjamin Franzke voted on patch set 2 V +1 CR +1 11/21/22, 12:51
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 11/21/22, 13:18
-
Nikita Hovratov merged patch set 3 11/21/22, 13:19