Review main Merged

76758[BUGFIX] Avoid undefined array keys in Indexer

Chris Müller CR +2 V +2 Easy +2 −2 updated 11/22/22, 23:08

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Chris Müller uploaded patch set 1 11/21/22, 12:03

  2. core-ci voted on patch set 1 V +1 11/21/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34036

  3. Oliver Klee commented on patch set 1 11/21/22, 12:20

    Indexer.php:235

    While we're touching these two lines anyway, we should also add the int cast to prevent errors when the method gets native types.
  4. Chris Müller uploaded patch set 2 V +1 11/21/22, 12:45

  5. Chris Müller commented on patch set 2 11/21/22, 12:46

    Indexer.php:235 Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/21/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34040

  7. Oliver Klee voted on patch set 2 CR +1 11/21/22, 13:19

  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 11/22/22, 21:04

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 11/22/22, 23:08

  10. Stefan Bürk merged patch set 3 11/22/22, 23:08