76766[BUGFIX] Use correct ordering of nl2br & htmlspecialchars
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Anja Leichsenring +1
- Stefan Froemken +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2024
-
Georg Ringer uploaded patch set 1 11/22/22, 10:38
-
Georg Ringer commented on patch set 1 11/22/22, 10:39
This change is ready for review. -
Anja Leichsenring updated the commit message in patch set 2 11/22/22, 10:40
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 11/22/22, 10:41
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 11/22/22, 10:43
-
core-ci voted on patch set 1 V +1 11/22/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34064
-
core-ci voted on patch set 2 V +1 11/22/22, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34065
-
Oliver Klee voted on patch set 2 CR +1 11/22/22, 10:57
-
Markus Klein voted on patch set 2 V +1 CR +1 11/22/22, 11:01
-
Stefan Froemken commented on patch set 2 V +1 CR +1 11/22/22, 11:20
Works, but <source> A regular text element with header and bodytext fields </source> Will add br before the translated output. What do you think about a trim in getDescription()? -
Stefan Froemken commented on patch set 2 11/22/22, 11:23
Sorry. NewContentElementController::getWizardItem(). Add trim for translation of description -
Georg Ringer uploaded patch set 3
CR +1V +111/22/22, 11:48 -
Oliver Klee voted on patch set 3 CR +1 11/22/22, 11:52
-
Stefan Froemken commented on patch set 3 V +1 CR +1 11/22/22, 11:53
Yeah. Patch 3 is nice. -
core-ci voted on patch set 3 V +1 11/22/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34070
-
Anja Leichsenring updated the commit message in patch set 4
CR +1V +111/22/22, 12:05 -
Anja Leichsenring voted on patch set 4 V +1 CR +1 11/22/22, 12:06
-
Oliver Klee voted on patch set 4 CR +1 11/22/22, 12:11
-
core-ci voted on patch set 4 V +1 11/22/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34073
-
Stefan Froemken voted on patch set 4 V +1 CR +1 11/22/22, 12:38
-
Nikita Hovratov voted on patch set 4 V +2 CR +2 11/22/22, 21:16
-
Nikita Hovratov commented on patch set 4 V -1 CR +1 11/22/22, 21:19
conflict in backport, will fix it before merging into main. -
Nikita Hovratov voted on patch set 4 V +2 CR +2 11/22/22, 21:35
-
Nikita Hovratov merged patch set 5 11/22/22, 21:35