Review main Merged

76769[FEATURE] Add "Edit Metadata" button to element information view

Stefan Froemken CR +2 V +2 Normal +52 −2 updated 09/19/23, 18:19

Commit message

This introduces a new "Edit Metadata" button
to the element information view of files,
allowing to directly edit the file's
Metadata without losing the context.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2940

Show 1015 earlier messages
  1. Stefan Froemken uploaded patch set 1 11/23/22, 11:19

  2. Andreas Kienast commented on patch set 1 11/23/22, 11:24

    ElementInformationController.php:194

    afaik you have to check edit permissions for the current backend user.
  3. core-ci voted on patch set 1 V -1 11/23/22, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34109

  4. Stefan Froemken uploaded patch set 2 V -1 11/23/22, 12:34

  5. core-ci voted on patch set 2 V -1 11/23/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34111

  6. Stefan Froemken commented on patch set 2 11/23/22, 12:43

    Good point

    ElementInformationController.php:194 Reply

    Done
  7. Stefan Froemken uploaded patch set 3 V -1 11/23/22, 12:47

  8. core-ci voted on patch set 3 V +1 11/23/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34112

  9. Chris Müller uploaded patch set 4 V +1 12/04/22, 18:18

  10. core-ci voted on patch set 4 V +1 12/04/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34611

  11. Benni Mack commented on patch set 5 V +1 12/06/22, 10:49

    Published edit on patch set 4.
  12. core-ci voted on patch set 5 V +1 12/06/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34709

  13. Guido Schmechel commented on patch set 5 V +1 CR +1 12/15/22, 22:40

    Good catch :-)
  14. Oli Bartsch commented on patch set 5 CR -1 12/16/22, 15:15

    ElementInformationController.php:196

    Please have a look at https://github.com/TYPO3/typo3/blob/main/typo3/sysext/filelist/Classes/FileList.php#L505. I suggest to use the same checks here.

    ElementInformationController.php:209

    UriBuilder is already injected as service in this class.
  15. Stefan Froemken uploaded patch set 6 CR +1 V +1 12/20/22, 07:52

  1. Stefan Froemken commented on patch set 5 12/20/22, 07:52

    ElementInformationController.php:196 Reply

    Please follow isEditMetadataAllowed(). It already checks, if user has rights to edit sys_file_metadata

    ElementInformationController.php:209 Reply

    Done
  2. core-ci voted on patch set 6 V +1 12/20/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35239

  3. Stefan Froemken commented on patch set 6 05/22/23, 08:37

    ElementInformationController.php:196 Reply

    Can you please verify again? Or remove your -1?
  4. Oli Bartsch commented on patch set 6 05/24/23, 05:52

    ElementInformationController.php:196 Reply

    I can't follow TBH. The method is not called in the current patch, or do I miss something?
  5. Jasmina Ließmann uploaded patch set 7 V +1 06/07/23, 09:24

  6. core-ci voted on patch set 7 V +1 06/07/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42259

  7. Jasmina Ließmann uploaded patch set 8 V +1 06/07/23, 09:58

  8. Jasmina Ließmann commented on patch set 8 06/07/23, 10:00

    I rebased the patch and swapped the label on the new button to clarify the purpose. The file metadata could already be edited in the "References to this item" section below. The following point is still open: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76769/comment/3c4b6d40_321422c0/
  9. core-ci voted on patch set 8 V +1 06/07/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42262

  10. Benni Mack commented on patch set 8 07/04/23, 12:11

    Funny enough... I just had an issue today where somebody edited a relation within the ViewPopup and in there, they couldn't open the "change link" modal (because it was in a modal already).
  11. Oli Bartsch uploaded patch set 9 V +1 09/19/23, 17:50

  12. Oli Bartsch commented on patch set 9 V +1 CR +1 09/19/23, 17:50

    ElementInformationController.php:196 Reply

    Done
  13. Oliver Hader commented on patch set 9 09/19/23, 18:00

    RST path should be changed (`12.2` → `13.0`)
  14. Oli Bartsch uploaded patch set 10 CR +1 V +1 09/19/23, 18:01

  15. Oli Bartsch commented on patch set 10 V +1 CR +1 09/19/23, 18:02

    Reply

    Done
  16. Oliver Hader voted on patch set 10 CR +1 09/19/23, 18:02

  17. core-ci voted on patch set 9 V +1 09/19/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46815

  18. Stefan Bürk voted on patch set 10 CR -1 09/19/23, 18:08

  19. Stefan Bürk commented on patch set 11 CR +1 V +1 09/19/23, 18:10

    Published edit on patch set 10.
  20. Stefan Bürk voted on patch set 11 V +1 CR +1 09/19/23, 18:10

  21. core-ci voted on patch set 10 V +1 09/19/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46818

  22. Oli Bartsch voted on patch set 11 V +1 CR +1 09/19/23, 18:12

  23. core-ci voted on patch set 11 V +1 09/19/23, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46820

  24. Stefan Bürk voted on patch set 11 V +2 CR +2 09/19/23, 18:19

  25. Stefan Bürk merged patch set 12 09/19/23, 18:19