Review main Abandoned

76794[BUGFIX] Create predictable relative links to anchors/fragments

Benni Mack CR 0 V 0 Normal +104 −26 updated 07/05/23, 14:03

Commit message

Creating links only to a specific anchor (just "#mypage")
was built in typolink by checking various arguments (number of
QueryParameters, same site), and no full URL was generated.

This created conflicts with routed arguments within the current
URL. The solution now is to first generate the final URL,
then compare the URL parts to eventually only use the
fragment/anchor when other URL components are the same.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1625

  1. Benni Mack uploaded patch set 1 11/23/22, 17:28

  2. core-ci voted on patch set 1 V -1 11/23/22, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34125

  3. Benni Mack commented on patch set 2 V -1 11/23/22, 22:02

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 11/23/22, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34140

  5. Benni Mack uploaded patch set 3 V -1 12/20/22, 22:05

  6. core-ci voted on patch set 3 V +1 12/20/22, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35250

  7. Benni Mack updated the commit message in patch set 4 V +1 12/21/22, 10:11

  8. core-ci voted on patch set 4 V +1 12/21/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35265

  9. Benni Mack uploaded patch set 5 V +1 12/21/22, 16:28

  10. core-ci voted on patch set 5 V -1 12/21/22, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35281

  11. Benni Mack rebased onto patch set 6 V -1 12/22/22, 20:54

  12. core-ci voted on patch set 6 V -1 12/22/22, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35311

  13. Benni Mack uploaded patch set 7 V -1 12/22/22, 23:30

  14. core-ci voted on patch set 7 V +1 12/22/22, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35317

  15. Susi Moog voted on patch set 7 CR +1 12/23/22, 09:48

  16. Oli Bartsch voted on patch set 7 V +1 CR +1 01/10/23, 10:05

  17. Oli Bartsch uploaded patch set 8 CR +1 V +1 01/10/23, 10:09

  18. core-ci voted on patch set 8 V +1 01/10/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35639

  19. Oli Bartsch voted on patch set 8 V +1 CR +1 01/10/23, 10:27

  20. Oliver Hader commented on patch set 8 CR +1 01/10/23, 11:06

    See my comment, however most probably with this patch is better than before

    PageLinkBuilder.php:501 Unresolved

    There might new still other side effects. In case the current request triggers rendering of another page that includes e.g. a menu (containing a link to the currently requested page again).
  21. Oliver Hader commented on patch set 8 CR -1 01/10/23, 11:28

    Unsure whether it's complete: * required URI `/content-examples/text/rich-text?hurga=1&cHash=ebc1904ae9f364be924406cdc25a6319` * generated URI `/content-examples/text/rich-text?hurga=1&cHash=ebc1904ae9f364be924406cdc25a6319#c30` (probably should be `#c30`)
  22. Benni Mack updated the commit message in patch set 9 CR +1 V +1 05/03/23, 09:28

  23. Oliver Hader rebased onto patch set 10 05/03/23, 11:53

  24. core-ci voted on patch set 10 V -1 05/03/23, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41519

  25. Benni Mack abandoned the change 07/05/23, 14:03

    don't know if that's the right way, abandoning the patch for the time being