Review main Merged

76795[BUGFIX] Omit warning when allowInconsistentLanguageHandling is active

Riny van Tiggelen CR +2 V +2 Easy +30 −10 updated 07/06/23, 19:54

Commit message

In case mod.web_layout.allowInconsistentLanguageHandling is set,
no warnings about inconsistent language usage should be displayed.
This is now properly checked in ContentFetcher, which would
otherwise add a warning message to the queue.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1724

  1. Riny van Tiggelen uploaded patch set 1 11/23/22, 17:51

  2. Riny van Tiggelen updated the commit message in patch set 2 11/23/22, 17:54

  3. core-ci voted on patch set 1 V +1 11/23/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34126

  4. Stefan Bürk commented on patch set 2 11/23/22, 18:05

    I guess this should be `GridColumnItem`
  5. core-ci voted on patch set 2 V +1 11/23/22, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34127

  6. Riny van Tiggelen updated the commit message in patch set 3 V +1 11/23/22, 18:06

  7. Riny van Tiggelen commented on patch set 3 11/23/22, 18:08

    Reply

    Good catch!
  8. core-ci voted on patch set 3 V +1 11/23/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34130

  9. Stefan Bürk commented on patch set 3 11/23/22, 18:21

    `determine`

    ContentFetcher.php:146

    Don't get this really - does this not mean, that if $language === 0 and if `allowInconsistentLanguageHandling` is not set or false, that no translation data is retrieved ? I mean, literally no translation data ? The check in GridColumnItem fetches this property and checks than the language against the context and so on. Here the setting is used as check. Only read on gerrit, so no testing yet .. maybe I'm just only on the wrong track here.
  10. Riny van Tiggelen updated the commit message in patch set 4 V +1 11/23/22, 19:48

  11. core-ci voted on patch set 4 V +1 11/23/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34137

  12. Riny van Tiggelen commented on patch set 4 11/23/22, 19:57

    Reply

    Done

    ContentFetcher.php:146 Reply

  13. Riny van Tiggelen uploaded patch set 5 V +1 01/05/23, 13:14

  14. Riny van Tiggelen commented on patch set 5 01/05/23, 13:16

    ContentFetcher.php:146 Reply

    I have changed the check to only make it hide the flashmessage, otherwise it wasn't possible anymore to translate content elements.
  15. core-ci voted on patch set 5 V +1 01/05/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35487

  16. Benni Mack updated the commit message in patch set 6 V +1 05/03/23, 09:27

  17. Oli Bartsch uploaded patch set 7 07/06/23, 18:22

  18. Oli Bartsch commented on patch set 7 V +1 CR +1 07/06/23, 18:22

    ContentFetcher.php:146 Reply

    Done
  19. Benni Mack uploaded patch set 8 CR +1 V +1 07/06/23, 18:37

  20. core-ci voted on patch set 7 V +1 07/06/23, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43800

  21. core-ci voted on patch set 8 V +1 07/06/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43806

  22. Oli Bartsch voted on patch set 8 V +1 CR +1 07/06/23, 19:28

  23. Benni Mack voted on patch set 8 V +2 CR +2 07/06/23, 19:53

  24. Benni Mack merged patch set 9 07/06/23, 19:54