76795[BUGFIX] Omit warning when allowInconsistentLanguageHandling is active
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1724
-
Riny van Tiggelen uploaded patch set 1 11/23/22, 17:51
-
Riny van Tiggelen updated the commit message in patch set 2 11/23/22, 17:54
-
core-ci voted on patch set 1 V +1 11/23/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34126
-
Stefan Bürk commented on patch set 2 11/23/22, 18:05
I guess this should be `GridColumnItem` -
core-ci voted on patch set 2 V +1 11/23/22, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34127
-
Riny van Tiggelen updated the commit message in patch set 3
V +111/23/22, 18:06 -
Riny van Tiggelen commented on patch set 3 11/23/22, 18:08
Reply
Good catch! -
core-ci voted on patch set 3 V +1 11/23/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34130
-
Stefan Bürk commented on patch set 3 11/23/22, 18:21
`determine`ContentFetcher.php:146Don't get this really - does this not mean, that if $language === 0 and if `allowInconsistentLanguageHandling` is not set or false, that no translation data is retrieved ? I mean, literally no translation data ? The check in GridColumnItem fetches this property and checks than the language against the context and so on. Here the setting is used as check. Only read on gerrit, so no testing yet .. maybe I'm just only on the wrong track here. -
Riny van Tiggelen updated the commit message in patch set 4
V +111/23/22, 19:48 -
core-ci voted on patch set 4 V +1 11/23/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34137
-
Riny van Tiggelen commented on patch set 4 11/23/22, 19:57
Reply
DoneContentFetcher.php:146ReplyIndeed, if that configuration is set no translation data should be retrieved. Atleast, that was the original intent for the setting: https://git.typo3.org/typo3/typo3/-/blob/TYPO3_7-6/typo3/sysext/core/Documentation/Changelog/7.6/Feature-71196-DisallowLocalizationMixtures.rst and also mentioned in the documentation: https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/Mod.html#allowinconsistentlanguagehandling This check was present in the old page module: https://git.typo3.org/typo3/typo3/-/blob/9.5/typo3/sysext/backend/Classes/View/PageLayoutView.php#L2904-2911 -
Riny van Tiggelen uploaded patch set 5
V +101/05/23, 13:14 -
Riny van Tiggelen commented on patch set 5 01/05/23, 13:16
ContentFetcher.php:146ReplyI have changed the check to only make it hide the flashmessage, otherwise it wasn't possible anymore to translate content elements. -
core-ci voted on patch set 5 V +1 01/05/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35487
-
Benni Mack updated the commit message in patch set 6
V +105/03/23, 09:27 -
Oli Bartsch uploaded patch set 7 07/06/23, 18:22
-
Oli Bartsch commented on patch set 7 V +1 CR +1 07/06/23, 18:22
ContentFetcher.php:146ReplyDone -
Benni Mack uploaded patch set 8
CR +1V +107/06/23, 18:37 -
core-ci voted on patch set 7 V +1 07/06/23, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43800
-
core-ci voted on patch set 8 V +1 07/06/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43806
-
Oli Bartsch voted on patch set 8 V +1 CR +1 07/06/23, 19:28
-
Benni Mack voted on patch set 8 V +2 CR +2 07/06/23, 19:53
-
Benni Mack merged patch set 9 07/06/23, 19:54