Review main Merged

76803[TASK] Replace prophecy in EXT:form FormDefinitionArrayConverterTest

Nikita Hovratov CR +2 V +2 Easy +5 −12 updated 11/24/22, 13:10

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Nikita Hovratov uploaded patch set 1 11/24/22, 08:35

  2. core-ci voted on patch set 1 V +1 11/24/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34160

  3. Oliver Klee voted on patch set 1 V +1 11/24/22, 08:49

  4. Oliver Klee commented on patch set 1 11/24/22, 08:51

    FormDefinitionArrayConverterTest.php:67

    Do we need the accessible mock here? Or could we use the mock builder with skipping the original constructor?
  5. Nikita Hovratov commented on patch set 1 11/24/22, 09:00

    FormDefinitionArrayConverterTest.php:67 Reply

    Yes, it makes these two protected methods accessible.
  6. Oliver Klee commented on patch set 1 CR +1 11/24/22, 09:09

    FormDefinitionArrayConverterTest.php:67 Reply

    Ack
  7. Georg Ringer voted on patch set 1 V +1 CR +1 11/24/22, 13:06

  8. Nikita Hovratov voted on patch set 1 V +2 CR +2 11/24/22, 13:10

  9. Nikita Hovratov merged patch set 2 11/24/22, 13:10