Review main Merged

76804[TASK] Drop fallback for explode calls in GeneralUtility

Oliver Klee CR +2 V +2 Easy +3 −3 updated 11/24/22, 14:31

Commit message

In PHP < 8.0, `explode` could return `false`. Starting with PHP 8.0,
`explode` will always return an array. Hence, no check and fallback
for `false` is needed anymore.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Klee uploaded patch set 1 11/24/22, 10:55

  2. core-ci voted on patch set 1 V +1 11/24/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34164

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 11/24/22, 13:55

    Can this get detected by phpstan?
  4. Oliver Klee commented on patch set 1 11/24/22, 13:59

    Reply

    Kind of: PHPStan has detected this in my GU::*explode cleanup patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76747 (I have no idea why PHPStan does not detect this without the annotations cleanup, though.)
  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 11/24/22, 14:30

  6. Nikita Hovratov merged patch set 2 11/24/22, 14:31