Review main Merged

76805[BUGFIX] Allow empty end date for scheduler task

Georg Ringer CR +2 V +2 Easy +3 −3 updated 02/09/23, 10:01

Commit message

An empty end date of a scheduler task is valid and must be allowed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2734

Show 89 earlier messages
  1. Georg Ringer uploaded patch set 1 11/24/22, 12:43

  2. core-ci voted on patch set 1 V +1 11/24/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34169

  3. Georg Ringer commented on patch set 1 11/25/22, 10:07

    This change is ready for review.
  4. Oliver Klee commented on patch set 1 11/25/22, 10:22

    SchedulerModuleController.php:793

    $endTime is not a boolean and should not be used as one. Let’s have an instance ofcheck instead.
  5. Oliver Klee commented on patch set 1 11/25/22, 11:29

    SchedulerModuleController.php:793 Reply

    Damn you autocorrect. This should read "instanceof check" instead.
  6. Stefan Bürk uploaded patch set 2 V +1 11/26/22, 17:57

  7. Stefan Bürk commented on patch set 2 11/26/22, 17:58

    Okay, no error anymore - but it autofills the endtime with the start time. Which does not happen in v11. Not sure if this is correct and where this is comming from.

    SchedulerModuleController.php:793 Reply

    "instanceof check" on a integer type variable ? Man, I missed a lot if this is the way to go. Going to change it to $endtime > 0, okay for you ?
  8. Stefan Bürk commented on patch set 2 11/26/22, 17:58

    SchedulerModuleController.php:793 Reply

    Done
  9. Stefan Bürk commented on patch set 2 11/26/22, 17:58

    Reply

    removing resolved on here ;)
  1. core-ci voted on patch set 2 V +1 11/26/22, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34265

  2. Oliver Klee commented on patch set 2 11/26/22, 18:27

    SchedulerModuleController.php:793 Reply

    Oh, haha, I was thinking along the lines of `DateTime` (as I currently am dealing a lot with those in one of my extensions), not UNIX timestamp. :-D Then I propose this: … $endTime !== 0 && $endTime < $startTime) {
  3. Oliver Klee commented on patch set 2 11/26/22, 18:28

    SchedulerModuleController.php:793 Reply

    Ah, yes > 0 is perfect. Thanks!
  4. Stefan Bürk commented on patch set 2 11/26/22, 18:29

    SchedulerModuleController.php:793 Reply

    a negative timestamp would not make much sense ;)
  5. Georg Ringer rebased onto patch set 3 V +1 12/06/22, 14:42

  6. core-ci voted on patch set 3 V +1 12/06/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34723

  7. Oliver Klee wrote 12/06/22, 15:10

    Removed cc Oliver Klee.
  8. Jochen Roth uploaded patch set 4 V +1 02/07/23, 14:58

  9. Jochen Roth commented on patch set 4 02/07/23, 15:00

    @Georg, changed the condition so `{f:format.date(format:'H:i d-m-Y', date:currentData.end)}` is not used when end date is empty. Otherwise we end up having a datt set in the input field.
  10. core-ci voted on patch set 4 V +1 02/07/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37295

  11. Josef Glatz voted on patch set 4 V +1 CR +1 02/08/23, 10:53

  12. Josef Glatz commented on patch set 4 02/08/23, 10:55

    This patch fixes exactly what it states. I found another grumpy thing around enddate in https://forge.typo3.org/issues/99878. But let us fix that as a separate patch (talked to Georg)
  13. Jochen Roth uploaded patch set 5 CR +1 V +1 02/08/23, 13:33

  14. core-ci voted on patch set 5 V +1 02/08/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37367

  15. Josef Glatz updated the commit message in patch set 6 V +1 02/08/23, 14:22

  16. Josef Glatz commented on patch set 6 V +1 CR +1 02/08/23, 14:31

    Thanks folks!
  17. core-ci voted on patch set 6 V +1 02/08/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37379

  18. Stefan Bürk commented on patch set 6 V +1 CR +1 02/08/23, 15:32

    Reply

    Done
  19. Stefan Bürk voted on patch set 6 CR -1 02/08/23, 15:33

  20. Stefan Bürk updated the commit message in patch set 7 CR +1 V +1 02/08/23, 15:33

  21. Stefan Bürk voted on patch set 7 V +1 CR +1 02/08/23, 15:33

  22. core-ci voted on patch set 7 V +1 02/08/23, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37384

  23. Josef Glatz voted on patch set 7 V +1 CR +1 02/08/23, 15:52

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 02/09/23, 10:01

  25. Andreas Kienast merged patch set 8 02/09/23, 10:01