Review main Merged

76806[BUGFIX] Make backdrop for EXT:recycler confirmations static

Andreas Kienast CR +2 V +2 Normal +47 −35 updated 12/01/22, 16:09

Commit message

The confirmation in modal windows of EXT:recycler may run long
running tasks, depending on the database structure and amount of
data. It was possible to close the modal by clicking the backdrop,
while the actions still run which may lead to undefined behavior
when the recycler is used. The backdrop is now made static.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Andreas Kienast uploaded patch set 1 11/24/22, 13:24

  2. core-ci voted on patch set 1 V +1 11/24/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34171

  3. Andreas Kienast uploaded patch set 2 V +1 11/25/22, 12:47

  4. core-ci voted on patch set 2 V -1 11/25/22, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34216

  5. Andreas Kienast rebased onto patch set 3 V -1 11/25/22, 14:07

  6. core-ci voted on patch set 3 V -1 11/25/22, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34227

  7. core-ci voted on patch set 3 V +1 11/25/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34227

  8. Oli Bartsch updated the commit message in patch set 4 V +1 12/01/22, 15:53

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 12/01/22, 15:53

  10. core-ci voted on patch set 4 V +1 12/01/22, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34511

  11. Josef Glatz commented on patch set 4 V +1 CR +1 12/01/22, 16:05

    nice catch, thank you Andy!
  12. Benni Mack voted on patch set 4 V +1 CR +1 12/01/22, 16:08

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 12/01/22, 16:09

  14. Andreas Kienast merged patch set 5 12/01/22, 16:09